C++/VB - Newbie - Help tiding code !!

Asked By Jez

27-Jan-10 12:56 PM

The vbs code below does as I would expect, but I think there must be a
better way of doing the for each loops.
Can any one help / advise !
Thanks

' Instantiate the connection and log in to OpenLDAP
Set oConn = CreateObject("ADODB.Connection")
oConn.Provider = "ADsDSOObject"
oConn.Open "ADs Provider", "USERNAME", "PASSWORD"

' Build the LDAP search condition...
vSearch = "(cn=*)"


' Execute the search...
Set oRS = oConn.Execute("<LDAP://10.10.10.1:389/cn=Devices>;" &
vSearch & ";cn,guid,id")

' Create an array of returned values
vCount = 0
While not oRS.EOF

For Each vCN in oRS.Fields("cn").value
For Each vID in oRS.Fields("id").value
For Each vGUID in oRS.Fields("guid").value

WScript.Echo vCN & " = " & vID & " - " & vGUID

Next
Next
Next

vCount = vCount + 1
oRS.MoveNext
Wend

27-Jan-10 08:46 AM

The loop should be similar to:
==========
While not oRS.EOF

vCN = oRS.Fields("cn").value
vID = oRS.Fields("id").value
vGUID = oRS.Fields("guid").value

WScript.Echo vCN & " = " & vID & " - " & vGUID

vCount = vCount + 1
oRS.MoveNext
Wend
=======
However, there are no "id" or "guid" attributes. You may want the
sAMAccountName attribute, which is the "pre-Windows 2000 logon" name of
users (and computers and groups). This is sometimes called the userID of
users. GUID is a property method, not an attribute, and cannot be retrieved
using ADO. You can retrieve the objectGUID attribute instead, but this is a
byte array, so you need a function to convert it into a string. For example
the following function:
===========
Function OctetToHexStr(ByVal arrbytOctet)
' Function to convert OctetString (byte array) to Hex string.
Dim k

OctetToHexStr = ""
For k = 1 To Lenb(arrbytOctet)
OctetToHexStr = OctetToHexStr _
& Right("0" & Hex(Ascb(Midb(arrbytOctet, k, 1))), 2)
Next
End Function
=========
Finally, your LDAP filter, "(cn=*)" will return just about all objects in
Active Directory. If you want to only retrieve user objects use the filter:

(&(objectCategory=person)(objectClass=user))

--
Richard Mueller
MVP Directory Services
Hilltop Lab - http://www.rlmueller.net
--

27-Jan-10 07:54 PM

On 27 Jan, 13:46, "Richard Mueller [MVP]" <rlmueller-
ed
a
le
2)
in
r:

Hi Richard
Many thanks for your reply.